DOC-5150 and DOC-5151 JavaScript and C# vector json examples #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwdougherty
approved these changes
Apr 28, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Coupla nits. Otherwise, LGTM.
|
|
||
| [Redis Query Engine]({{< relref "/develop/interact/search-and-query" >}}) | ||
| lets you index vector fields in [hash]({{< relref "/develop/data-types/hashes" >}}) | ||
| enables you to index vector fields in [hash]({{< relref "/develop/data-types/hashes" >}}) |
Collaborator
There was a problem hiding this comment.
Looks like the SG prefers "lets you", if I read that correctly. Not a big deal.
Contributor
Author
There was a problem hiding this comment.
@dwdougherty This is what I get for asking Cursor for style advice :-( It actually said that the guide prefers "enables" (which it doesn't, you are correct), and it has rewritten some of the other stuff in a way that I'm not sure is better. It's as well I checked the text again because I've now noticed it has even trashed some quite useful links (I've added them back in now).
I'll be more careful next time I try using AI for this sort of thing!
Co-authored-by: David Dougherty <[email protected]>
Contributor
Author
|
@dwdougherty Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-5150 and DOC-5151
For the C# examples, I'm not sure if it's clearer to define the
GetEmbeddingandGetFloatEmbeddingfunctions the way I have, or if it would be better to have theGetFloatEmbeddingas it is with another function to convert the result to a binary string. I guess it doesn't make much difference but I'd be happy to hear any thoughts about whether one approach is better than the other.